Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #64955

Closed
wants to merge 37 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 1, 2019

Successful merges:

Failed merges:

r? @ghost

Mark-Simulacrum and others added 30 commits September 23, 2019 19:27
We're not quite ready to ship parallel compilers by default, but the alt
builders are not used too much (in theory), so we believe that shipping
a possibly-broken compiler there is not too problematic.
This changes the default parallelism for parallel compilers to one,
instead of the previous default, which was "num cpus". This is likely
not an optimal default long-term, but it is a good default for testing
whether parallel compilers are not a significant regression over a
sequential compiler.

Notably, this in theory makes a parallel-enabled compiler behave
exactly like a sequential compiler with respect to the jobserver.
GuillaumeGomez and others added 7 commits October 1, 2019 11:48
…xcrichton

Make all alt builders produce parallel-enabled compilers

We're not quite ready to ship parallel compilers by default, but the alt
builders are not used too much (in theory), so we believe that shipping
a possibly-broken compiler there is not too problematic.

r? @nikomatsakis
…i-refactor, r=wesleywiser

SelfProfiler API refactoring and part one of event review

This PR refactors the `SelfProfiler` a little bit so that most profiling methods are RAII-based. The codegen backend code already had something similar, this refactoring pulls this functionality up into `SelfProfiler` itself, for general use.

The second commit of this PR is a review and update of the existing events we are already recording. Names have been made more consistent. CGU names have been removed from event names. They will be added back in when function parameter recording is implemented.

There is still some work to be done for adding new events, especially around trait resolution and the incremental system.

r? @wesleywiser
…i-obk

[const-prop] Handle remaining MIR Rvalue cases

r? @oli-obk
syntax: cleanup param, method, and misc parsing

Do some misc cleanup of the parser:
- Method and parameter parsing is refactored.
- A parser for `const | mut` is introduced that rust-lang#64588 can reuse.
- Some other misc parsing.

Next up in a different PR:
- ~Implementing rust-lang#64252 -- maybe some other time...
- Heavily restructuring up `item.rs` which is a mess (hopefully, no promises ^^).

r? @petrochenkov
@Centril
Copy link
Contributor Author

Centril commented Oct 1, 2019

@bors r+ p=5 rollup=never

@bors
Copy link
Contributor

bors commented Oct 1, 2019

📌 Commit 35e8755 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 1, 2019
@bors
Copy link
Contributor

bors commented Oct 1, 2019

⌛ Testing commit 35e8755 with merge 972627fc1ed463edb432c0040938fbd593597cf2...

@bors
Copy link
Contributor

bors commented Oct 1, 2019

💔 Test failed - checks-azure

@rust-highfive
Copy link
Collaborator

The job dist-powerpc-linux of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-01T13:02:33.1829007Z note: the compiler unexpectedly panicked. this is a bug.
2019-10-01T13:02:33.1829086Z 
2019-10-01T13:02:33.1829545Z note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
2019-10-01T13:02:33.1829607Z 
2019-10-01T13:02:33.1829868Z note: rustc 1.40.0-nightly (972627fc1 2019-10-01) running on x86_64-unknown-linux-gnu
2019-10-01T13:02:33.1829917Z 
2019-10-01T13:02:33.1830381Z note: compiler flags: -Z dual-proc-macros -Z external-macro-backtrace -Z unstable-options -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=2 -C debuginfo=0 -C linker=powerpc-unknown-linux-gnu-gcc -C link-args=-Wl,-rpath,$ORIGIN/../lib -C prefer-dynamic -C debug-assertions=n --crate-type lib
2019-10-01T13:02:33.1830734Z note: some of the compiler flags provided by cargo are hidden
2019-10-01T13:02:33.1830775Z 
2019-10-01T13:02:33.1864802Z [RUSTC-TIMING] crc32fast test:false 0.146
2019-10-01T13:02:33.1870447Z error: could not compile `crc32fast`.
---
2019-10-01T13:02:33.6740298Z == clock drift check ==
2019-10-01T13:02:33.6753440Z   local time: Tue Oct  1 13:02:33 UTC 2019
2019-10-01T13:02:35.9936218Z   network time: Tue, 01 Oct 2019 13:02:35 GMT
2019-10-01T13:02:35.9937125Z == end clock drift check ==
2019-10-01T13:02:38.4291611Z ##[error]Bash exited with code '1'.
2019-10-01T13:02:38.4342085Z ##[section]Starting: Upload CPU usage statistics
2019-10-01T13:02:38.4348902Z ==============================================================================
2019-10-01T13:02:38.4348979Z Task         : Bash
2019-10-01T13:02:38.4349052Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 1, 2019
@Centril Centril closed this Oct 1, 2019
@Centril Centril deleted the rollup-unxnwj5 branch October 1, 2019 14:09
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants